Create Task
Maniphest T1193

Implement Checkbox GUI element
Closed, ResolvedPublic
Actions

Description

create a checkbox as widget, derive it from IWidget with the relevant changes (set/get of checked status, etc.).

create graphics icons in this style: https://image.shutterstock.com/image-vector/checkbox-set-blank-checked-line-260nw-1062630557.jpg and make the widget use it.

Related Objects

sebastian created this task.May 3 2020, 2:43 PM
metal_dent removed metal_dent as the assignee of this task.Dec 26 2020, 12:19 PM
eppisai closed this task as Resolved.Dec 26 2020, 2:50 PM
BAndiT1983 reopened this task as Open.Jan 4 2021, 10:04 AM
BAndiT1983 added a subscriber: BAndiT1983.

There seems to be a problem with icons, as the on/off states look different.

  • It's better to use the "on"-icon and just remove the check mark for the off state, so they look the same
  • Off icon looks very jaggy

eppisai added a comment.EditedJan 4 2021, 2:46 PM

How about now? @BAndiT1983 I have just removed the tick from "on" icon svg

BAndiT1983 added a comment.Jan 4 2021, 2:54 PM

Jaggy edges are gone, but the outlines are still different. See the chamfered corners, one has less chamfering than the other.

sebastian added a comment.Jan 4 2021, 2:55 PM

The line of the checkbox still has a different thickness...

BAndiT1983 added a comment.Jan 4 2021, 2:58 PM

@eppisai Just take the checkbox SVG with the check mark, open in Inkscape, save it under new name for empty one and remove the check mark, then the boxes would look the same.

eppisai added a comment.Jan 4 2021, 3:39 PM

checkboxtrue_icon 1.svg725 B

In T1193#17441, @BAndiT1983 wrote:

@eppisai Just take the checkbox SVG with the check mark, open in Inkscape, save it under new name for empty one and remove the check mark, then the boxes would look the same.

I should have done this in 1st place, but was just hesitant to use new software, how about now?

BAndiT1983 added a comment.EditedJan 4 2021, 3:48 PM

Great! Looks much better. Please create a PR for it.

sebastian added a comment.Jan 4 2021, 4:03 PM

Perfect, thanks!

eppisai closed this task as Resolved.Jan 5 2021, 5:00 AM