Create Task
Maniphest T918

new footer broken in Chromium 64
Closed, ResolvedPublic
Actions

Description

The new footer looks broken in Chromium 64.

The content is out of the visible space left and right.

NixOS 17.09.2875.c2b668ee726
Xfce 4.12
Chromium 64.0.3282.119 (Developer Build)

davidak created this task.Jan 29 2018, 7:34 PM
davidak updated the task description. (Show Details)
davidak raised the priority of this task from to Needs Triage.
davidak added a subscriber: davidak.
sebastian assigned this task to BAndiT1983.Jan 30 2018, 6:13 PM
sebastian added a subscriber: sebastian.

What is your screen resolution davidak?

BAndiT1983 added a comment.Jan 30 2018, 6:16 PM

He told me yesterday that it is 1366x768 (see IRC log). We have to add new area to the theme or move current footer area out of the main container, then the shrinking works again.

sebastian added a comment.Jan 30 2018, 6:19 PM

so we need to get knee deep into the theme templates I assume. Will take a look.

BAndiT1983 added a comment.Jan 30 2018, 6:20 PM

Let me take a look, have got a bit of experience by now. See intern chat.

sebastian reassigned this task from BAndiT1983 to davidak.Jan 30 2018, 7:05 PM
sebastian added a subscriber: BAndiT1983.

Thanks BAndiT1983 for the fix!

davidak can you check it out and mark issue resolved when its confirmed fixed.

davidak added a comment.Jan 31 2018, 7:52 PM

The problem is fixed now. Thanks!

Should the width align with the rest of the website? I think such big footers are often even wider than the website content.

RexOr added a subscriber: RexOr.Feb 1 2018, 6:18 AM

It was intended to align with the website content yeah.

RexOr added a comment.Feb 2 2018, 6:41 PM

Still fixed?

davidak added a comment.Feb 2 2018, 11:54 PM

The initial problem is still fixed.

Looks better but still not perfectly aligned.

RexOr added a comment.Feb 3 2018, 7:08 AM

That's strange because the footer body appears wider than the page body on Palemoon and FF.

davidak closed this task as Resolved.Mar 16 2019, 7:01 PM

The footer has now the same width as the content (what looks good).

Tested in Chromium 72.0.3626.119 on 13" Notebook.

sebastian added a comment.Mar 16 2019, 7:26 PM

Great, thanks for checking!