Create Task
Maniphest T828

automated rcn calibration script suggestions
Open, NormalPublic
Actions

Description

I just tested the script (https://github.com/apertus-open-source-cinema/beta-software/blob/master/software/scripts/calibration.sh) and collected a few thoughts and ideas:

  1. rename the script to rcn_calibration.sh as there are many things that can be calibrated.
  1. what will happen if there are darkframes already stored in /opt/calibration/rcn?
  1. Can we integrate the validation Method 2 (https://wiki.apertus.org/index.php/Factory_Calibration#Method_2:) directly into the script?
  1. is "rm -rf $STORE" at the end required, isn't that potentially deleting other calibration stuff we place there in the future?
  1. Doesn't the "rm -rf $STORE/rcn" delete the darkframe we just calculated?
  1. Can we have a counter output during taking the 64 darkframes so we know where we are ("capturing darkframe 17 of 64") ?
sebastian created this task.Nov 14 2017, 5:54 PM
sebastian updated the task description. (Show Details)
sebastian raised the priority of this task from to Normal.
sebastian assigned this task to davidak.
sebastian added a project: AXIOM Beta Software.
sebastian moved this task to Backlog on the AXIOM Beta Software board.
sebastian added a subscriber: sebastian.
davidak added a comment.Nov 14 2017, 8:52 PM
  1. i suggest calling it factory_calibration.sh (or similar) as i intended it to do all calibrations needed before the camera get's shipped to the customer
  1. that would be problematic. (they will probaply just get overwritten) you shouldn't place anything there and the script cleans up behind itself...
  1. yes, is planned.
  1. you shoudn't place anything in there. it's just temporary files (i would put it in /tmp but that is a ramdisk with few space)
  1. it should be in /root (is it?)
  1. would be nice. needs some shell magic to refresh the screen. i will try
sebastian added a comment.EditedNov 14 2017, 9:16 PM
  1. lets do it one step at a time
  1. maybe its better to clean the dir before starting instead of after finishing, because that eliminates the problem when you start the script and interrupt the process.
  1. great
  1. ultimately we need a place to store the calibration files, /root is really just a temporary place. I thought /opt/calibration is that place but you are right its not optimal, there is this page by alex: https://wiki.apertus.org/index.php/Calibration_files
  1. right
davidak added a comment.Nov 14 2017, 9:48 PM
  1. then the camera is shipped with a bunch of random crap on it. the end result should be just the calibration files.
  1. sure. right now raw2dng needs the darkframe file in the same directory so i would execute it from /root. we can change it to also search for the file at a different place