Create Task
Maniphest T1171

fix TextAlign::TEXT_ALIGN_CENTER drawing
Closed, ResolvedPublic
Actions

Description

The text drawing with TextAlign::TEXT_ALIGN_CENTER somehow doesn't work well currently.

Short words like "FPS" or "WB" get centred correctly.

But longer words like "D. Gain" don't and get drawn like with TextAlign::TEXT_ALIGN_LEFT so something with the textwidth/blockwidth calculation seems to be off.

sebastian created this task.Apr 13 2020, 2:57 PM
sebastian triaged this task as Normal priority.
sebastian updated the task description. (Show Details)Apr 13 2020, 2:59 PM
sebastian added a comment.Apr 13 2020, 3:19 PM

The respective code line is https://github.com/apertus-open-source-cinema/AXIOM-Remote/blob/dev/Firmware/UI/Painter.cpp#L448

I suspect either textPixelWidth or textblockwidth get calculated wrong (and end up being 0).

BAndiT1983 added a comment.Apr 13 2020, 10:41 PM

Please check latest commit in the repo, it has a debug overlay now, which currently is only implemented for DrawText() and DrawIcon():

metal_dent added a comment.Apr 15 2020, 2:19 PM

I fixed the problem, should I create a PR?

sebastian added a comment.Apr 15 2020, 2:26 PM

Excellent!

Yes please!

sebastian closed this task as Resolved.Apr 15 2020, 2:43 PM

Wonderful!

Just compiled and flashed it: